Skip to content

Add a benchmark for property access using dynamic member lookup #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add a benchmark for property access using dynamic member lookup #254

wants to merge 1 commit into from

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jun 11, 2024 •
edited
Loading

To see how much #253 will improve performance

@kateinoigakukun kateinoigakukun deleted the katei/add-dml-benchmark branch June 11, 2024 12:19
@github-actions GitHub Actions
Copy link

Time Change: +2,541ms (21%) 🚨

Total Time: 11,680ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 21ms +2ms (7%) 🔍
Serialization/JavaScript function call from Swift 99ms +5ms (5%) 🔍
Serialization/Swift Int to JavaScript with assignment 339ms +24ms (7%) 🔍
Serialization/Swift Int to JavaScript with call 967ms +50ms (5%) 🔍
Serialization/JavaScript Number to Swift Int 313ms +18ms (5%) 🔍
Serialization/Swift String to JavaScript with call 1,046ms +64ms (6%) 🔍
Serialization/JavaScript String to Swift String 3,790ms +268ms (7%) 🔍
Property access/Dynamic member lookup 2,014ms +2,014ms (100%) 🆘
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 14ms -0ms
Serialization/Swift String to JavaScript with assignment 395ms +15ms (3%)
Object heap/Increment and decrement RC 2,668ms +80ms (3%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 2ms
Serialization/Call with JavaScript string directly 3ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kateinoigakukun